On Wed, Nov 15, 2017 at 12:04:26PM +0100, Maciej Purski wrote:
> +static void component_master_debugfs_add(struct master *m);
> +static void component_master_debugfs_del(struct master *m);
Please avoid forward declarations.
> +static int component_devices_show(struct seq_file *s, void *data)
> +{
> + struct master *m = s->private;
> + struct component_match *match = m->match;
> + size_t i;
> +
> + mutex_lock(&component_mutex);
> + seq_puts(s, "master name
> status\n");
Would:
seq_printf(s, "%-40s %20s\n", "master name", "status");
be better - it becomes more obvious what is intended (that is for the
headings to line up with the data below.)
> + seq_puts(s,
> "-------------------------------------------------------------\n");
> + seq_printf(s, "%-40s %20s\n\n",
> + dev_name(m->dev), m->bound ? "bound" : "not bound");
> +
> + seq_puts(s, "device name
> status\n");
Ditto.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up
