On 11/17/2017 02:37 PM, Christophe JAILLET wrote: > If the last test in 'ioat_dma_self_test()' fails, we must release all > the allocated resources and not just part of them. > > Signed-off-by: Christophe JAILLET <[email protected]>
Good catch! Thanks! Acked-by: Dave Jiang <[email protected]> > --- > drivers/dma/ioat/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/ioat/init.c b/drivers/dma/ioat/init.c > index 2f31d3d0caa6..7792a9186f9c 100644 > --- a/drivers/dma/ioat/init.c > +++ b/drivers/dma/ioat/init.c > @@ -390,7 +390,7 @@ static int ioat_dma_self_test(struct ioatdma_device > *ioat_dma) > if (memcmp(src, dest, IOAT_TEST_SIZE)) { > dev_err(dev, "Self-test copy failed compare, disabling\n"); > err = -ENODEV; > - goto free_resources; > + goto unmap_dma; > } > > unmap_dma: >
