On 11/20/2017 04:02 PM, James Hogan wrote:
From: James Hogan <[email protected]>The MIPS_CPS_NS16550_BASE and MIPS_CPS_NS16550_SHIFT options have no defaults for non-Malta platforms which select SYS_SUPPORTS_MIPS_CPS (i.e. the pistachio and generic platforms). This is problematic for automated allyesconfig and allmodconfig builds based on these platforms, since make silentoldconfig tries to ask the user for values, and especially since v4.15 where the default platform was switched to generic. Default these options to 0 and arrange for MIPS_CPS_NS16550 to be no when using that default base address, so that the option only has an effect when the default is provided (i.e. Malta) or when a value is provided by the user. Fixes: 609cf6f2291a ("MIPS: CPS: Early debug using an ns16550-compatible UART") Signed-off-by: James Hogan <[email protected]> Reviewed-by: Paul Burton <[email protected]> Cc: Ralf Baechle <[email protected]> Cc: Guenter Roeck <[email protected]> Cc: [email protected] --- Guenter: I'm guessing this is the problem you're referring to.
Yes. Tested-by: Guenter Roeck <[email protected]> mips:allmodconfig still fails to build with this patch applied, but elsewhere. In file included from /opt/buildbot/slave/hwmon-testing/build/include/linux/bcma/bcma.h:10:0, from /opt/buildbot/slave/hwmon-testing/build/drivers/bcma/bcma_private.h:9, from /opt/buildbot/slave/hwmon-testing/build/drivers/bcma/main.c:8: /opt/buildbot/slave/hwmon-testing/build/include/linux/bcma/bcma_driver_pci.h:218:24: error: field 'pci_controller' has incomplete type Guenter
