Re: linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282: bad if condition ?

[Corey Minyard]

On 11/27/2017 06:32 AM, David Binderman wrote:

Hello there,

linux-4.15-rc1/drivers/char/ipmi/ipmi_si_intf.c:2282]: (style) Expression is 
always false because 'else if' condition matches previous condition at line 2279

Source code is

     if (new_smi->pdev) {
         platform_device_unregister(new_smi->pdev);
         new_smi->pdev = NULL;
     } else if (new_smi->pdev) {

Suggest code rework.

Yeah, definitely wrong, fix is queues for next release.  Thanks.

-corey

Regards

David Binderman