From 715977ac0090cf3ee8ddc339c292434e20a9c93d Mon Sep 17 00:00:00 2001 From: Elena Reshetova Date: Fri, 24 Nov 2017 10:02:48 +0200 Subject: [PATCH] dm: fix the missing increment for dm_dev_internal.count The commit 2a0b4682e09d76466f7b8f5e347ae2ff02f033af mistakenly forgotten one case where refcount must be incremented. Fix this. Reported-by: Alasdair G Kergon Signed-off-by: Elena Reshetova --- drivers/md/dm-table.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c index 88130b5..eb0ba2a 100644 --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -453,14 +453,19 @@ int dm_get_device(struct dm_target *ti, const char *path, fmode_t mode, refcount_set(&dd->count, 1); list_add(&dd->list, &t->devices); + *result = dd->dm_dev; + return 0; + + } - } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) { + if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) { r = upgrade_mode(dd, mode, t->md); if (r) return r; - refcount_inc(&dd->count); } + refcount_inc(&dd->count); + *result = dd->dm_dev; return 0; } -- 2.7.4