4.4-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Chris Wilson <[email protected]>


[ Upstream commit 3db93756b501e5f0a3951c79cfa9ed43c26d3455 ]

mm->color_adjust() compares the hole with its neighbouring nodes. They
only abutt before we restrict the hole, so we have to apply color_adjust
before we apply the range restriction.

Signed-off-by: Chris Wilson <[email protected]>
Reviewed-by: Joonas Lahtinen <[email protected]>
Signed-off-by: Daniel Vetter <[email protected]>
Link: 
http://patchwork.freedesktop.org/patch/msgid/[email protected]
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 drivers/gpu/drm/drm_mm.c |   16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
@@ -262,14 +262,12 @@ static void drm_mm_insert_helper_range(s
 
        BUG_ON(!hole_node->hole_follows || node->allocated);
 
-       if (adj_start < start)
-               adj_start = start;
-       if (adj_end > end)
-               adj_end = end;
-
        if (mm->color_adjust)
                mm->color_adjust(hole_node, color, &adj_start, &adj_end);
 
+       adj_start = max(adj_start, start);
+       adj_end = min(adj_end, end);
+
        if (flags & DRM_MM_CREATE_TOP)
                adj_start = adj_end - size;
 
@@ -475,17 +473,15 @@ static struct drm_mm_node *drm_mm_search
                               flags & DRM_MM_SEARCH_BELOW) {
                u64 hole_size = adj_end - adj_start;
 
-               if (adj_start < start)
-                       adj_start = start;
-               if (adj_end > end)
-                       adj_end = end;
-
                if (mm->color_adjust) {
                        mm->color_adjust(entry, color, &adj_start, &adj_end);
                        if (adj_end <= adj_start)
                                continue;
                }
 
+               adj_start = max(adj_start, start);
+               adj_end = min(adj_end, end);
+
                if (!check_free_hole(adj_start, adj_end, size, alignment))
                        continue;
 


Reply via email to