4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Damien Le Moal <damien.lem...@wdc.com>

commit 4a109032e3941413d8a029f619543fc5aec1d26d upstream.

The three values starting at byte 8 of the Zoned Block Device
Characteristics VPD page B6h are 32 bits values, not 64bits. So use
get_unaligned_be32() to retrieve the values and not get_unaligned_be64()

Fixes: 89d947561077 ("sd: Implement support for ZBC devices")
Signed-off-by: Damien Le Moal <damien.lem...@wdc.com>
Reviewed-by: Bart Van Assche <bart.vanass...@wdc.com>
Reviewed-by: Johannes Thumshirn <jthumsh...@suse.de>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Signed-off-by: Martin K. Petersen <martin.peter...@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>

---
 drivers/scsi/sd_zbc.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- a/drivers/scsi/sd_zbc.c
+++ b/drivers/scsi/sd_zbc.c
@@ -375,15 +375,15 @@ static int sd_zbc_read_zoned_characteris
        if (sdkp->device->type != TYPE_ZBC) {
                /* Host-aware */
                sdkp->urswrz = 1;
-               sdkp->zones_optimal_open = get_unaligned_be64(&buf[8]);
-               sdkp->zones_optimal_nonseq = get_unaligned_be64(&buf[12]);
+               sdkp->zones_optimal_open = get_unaligned_be32(&buf[8]);
+               sdkp->zones_optimal_nonseq = get_unaligned_be32(&buf[12]);
                sdkp->zones_max_open = 0;
        } else {
                /* Host-managed */
                sdkp->urswrz = buf[4] & 1;
                sdkp->zones_optimal_open = 0;
                sdkp->zones_optimal_nonseq = 0;
-               sdkp->zones_max_open = get_unaligned_be64(&buf[16]);
+               sdkp->zones_max_open = get_unaligned_be32(&buf[16]);
        }
 
        return 0;


Reply via email to