On Mon, Oct 30, 2017 at 4:47 PM, SF Markus Elfring
<[email protected]> wrote:
> + if (t)
> + goto report_failure;
>
> for (t = 0, mask = BIT(0); t < chip->ngpio; t++, mask <<= 1) {
> const char *label;
> @@ -758,8 +753,13 @@ static void mcp23s08_dbg_show(struct seq_file *s, struct
> gpio_chip *chip)
> /* NOTE: ignoring the irq-related registers */
> seq_puts(s, "\n");
> }
> -done:
> +unlock:
> mutex_unlock(&mcp->lock);
> + return;
> +
> +report_failure:
> + seq_puts(s, " I/O Error\n");
> + goto unlock;
> }
This is spaghetti coding. Not applied.
https://en.wikipedia.org/wiki/Spaghetti_code
Yours,
Linus Walleij
