On Thu, Nov 30, 2017 at 3:29 PM, Adrian Hunter <adrian.hun...@intel.com> wrote: > On 29/11/17 01:03, Atul Garg wrote: [] >> diff --git a/drivers/mmc/host/sdhci-pci-arasan.c >> b/drivers/mmc/host/sdhci-pci-arasan.c >> new file mode 100644 >> index 0000000..6529f30 >> --- /dev/null >> +++ b/drivers/mmc/host/sdhci-pci-arasan.c >> @@ -0,0 +1,314 @@ >> +/* >> + * Copyright (C) 2017 Arasan Chip Systems Inc., >> + * >> + * Author: Atul Garg <ag...@arasan.com> >> + * >> + * This software is licensed under the terms of the GNU General Public >> + * License version 2, as published by the Free Software Foundation, and >> + * may be copied, distributed, and modified under those terms. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + */
Would it make sense to use the new SPDX ids here? e.g something like this instead? >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Copyright (C) 2017 Arasan Chip Systems Inc. >> + * >> + * Author: Atul Garg <ag...@arasan.com> >> + */ Shorter and cleaner! In any case you likely do not want a trailing comma after Arasan Chip Systems Inc. -- Cordially Philippe Ombredanne
