Hi Arnaldo, 2017-12-05 0:45 GMT+09:00 Arnaldo Carvalho de Melo <[email protected]>: > Em Tue, Dec 05, 2017 at 12:05:18AM +0900, Namhyung Kim escreveu: >> Hi SeokHo, >> >> On Sun, Dec 3, 2017 at 10:50 PM, Song Seok Ho <[email protected]> wrote: >> > If perf_session__new() returns NULL with use_browser set to 2 via --gtk >> > option >> > previously, perf dies quietly without printing any errors. >> > >> > The reason behind this is that GTK is not yet initialized when the caller >> > inside perf_session__new() is trying to print error message to the screen. >> > >> > Reorder code to print the messages to stdio when GTK is not yet ready. >> >> I'm ok with this change, but it needs to consider other error messages too. >> There are more pr_err() calls between perf_session__new() and >> setup_browser(), so I think they have same problem. > > So I think I can apply this one, with Namhyung's acked-by and then Song > can continue with followup patches? > > - Arnaldo >
I've sent a follow-up patch with a new title "[PATCH v2] perf tools: set browser mode right before setup_browser()" with Namhyung's Acked-by added. Addressing Namhyung's comment, I've moved the use_browser variable assignment code below when setup_browser() is called. Please let me know if it deserves to be in a different place. Thanks.
