Hi,
On Wed, Nov 29, 2017 at 8:27 AM, Ben Gainey <ben.gai...@arm.com> wrote:
> On Wed, 2017-11-29 at 05:02 -0800, Stephane Eranian wrote:
>> On Thu, Nov 23, 2017 at 7:22 AM, Arnaldo Carvalho de Melo
>> <a...@kernel.org> wrote:
>> >
>> > Em Wed, Nov 22, 2017 at 06:25:41PM -0600, Kim Phillips escreveu:
>> > > From: Ben Gainey <ben.gai...@arm.com>
>> > > @@ -405,7 +405,9 @@ jvmti_write_debug_info(void *agent, uint64_t
>> > > code, const char *file,
>> > > return -1;
>> > > }
>> > >
>> > > - flen = strlen(file) + 1;
>> > > + for (i = 0; i < nr_lines; ++i) {
>> > > + flen += strlen(file_names[i]) + 1;
>> > > + }
>> >
>> >
>> > Please follow the coding standard used in this file and in
>> > tools/perf,
>> > which is the kernel one.
>> >
>> > Thanks for providing instructions on how to reproduce the problem!
>> >
>> > Stephane, can you please Ack this?
>> >
>>
>> Trying to test this but do not see the source code from example, yet.
>
> Hi Stephane, sorry can you please clarify; were you expecting to see
> source embedded in the output from perf annotate, or are just missing
> the source for the reproducer, or something else?
>
No, I finally tracked down my issue. It was due to a broken perf build system
where it would not detect libdw-dev when in fact it was there. I just posted
a patch to fix this. With that fix, I am able to test your patch and things
look good to me.
> If it is the former, then there is no source in the output, only line
> numbers and filenames, but this is not a regression (that I am aware
> of) as it was not there before the patch either.
>
Tested-by: Stephane Eranian <eran...@google.com>
>
>>
>> >
>> > - Arnaldo
>>
>>
> IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium. Thank you.
