On Sun, 2017-12-10 at 21:41 +0000, Maciej W. Rozycki wrote: > On Sun, 10 Dec 2017, SF Markus Elfring wrote: > > > Omit an extra message for a memory allocation failure in this function. > > > > This issue was detected by using the Coccinelle software. > > And the problem here is?
Markus' terrible commit messages. Generically, any OOM via a malloc like call has a dump_stack() which shows a stack trace unless __GFP_NOWARN is used. So this message is generally unnecessary as the dump_stack() will show the tc_bus_add_devices function name and (now hashed) value of the function address. What will be different is the particular slot # of the tc_dev will no longer be shown. Really though, if there's an OOM on the init, there are larger problems and the system will be unusable.
