On Tue, Dec 12, 2017 at 06:32:32PM -0800, Randy Dunlap wrote: > On 12/12/2017 06:14 PM, Yaowei Bai wrote: > > On Tue, Dec 12, 2017 at 09:20:56AM -0800, Randy Dunlap wrote: > >> On 12/11/2017 11:21 PM, Yaowei Bai wrote: > >>> On Mon, Dec 11, 2017 at 09:50:03PM -0800, David Rientjes wrote: > >>>> On Mon, 11 Dec 2017, Yaowei Bai wrote: > >>>> > >>>>> This patchset makes some *_is_* like functions return bool because > >>>>> these functions only use true or false as their return values. > >>>>> > >>>>> No functional changes. > >> > >> I agree with the idea that predicate-like functions are boolean functions > >> and should return bool. > > > > Then you can use Acked-by to support me. :) > > Sure, but I didn't keep the patch emails. > > Acked-by: Randy Dunlap <rdun...@infradead.org>
Thanks a lot. > > > >> Whether you can get someone to merge the patches is a different subject. > > > > The kernel development is not just developing hard codes. The talented > > guys develop new features and bugfixes, while the other ones do cleanups > > for them. These two parts of work are all welcome and should be > > accepted by our community. > > > >> > >>>> I think the concern about this type of patchset in the past is that it > >>>> is > >>>> unnecessary churn and makes it more time consuming to research git > >>>> history > >>>> without any significant improvement. > >>> > >>> While, relative to a modern computer with superb computional power, i > >>> think the additional time to search git history is negligable and this > >>> type of patchset is also a good practice for the kernel beginner guys. > >>> :) > >> > >> > >> -- > >> ~Randy > > > > -- > ~Randy
