On Wed 13-12-17 15:07:33, Kirill A. Shutemov wrote: [...] > The approach looks fine to me. > > But patch is rather large and hard to review. And how git mixed add/remove > lines doesn't help too. Any chance to split it up further?
I was trying to do that but this is a drop in replacement so it is quite hard to do in smaller pieces. I've already put the allocation callback cleanup into a separate one but this is about all that I figured how to split. If you have any suggestions I am willing to try them out. > One nitpick: I don't think 'chunk' terminology should go away with the > patch. Not sure what you mean here. I have kept chunk_start, chunk_node, so I am not really changing that terminology Thanks! -- Michal Hocko SUSE Labs
