Hi Linus, Peter, Ingo, Now that membarrier.c has been moved from kernel/ to kernel/sched/, should I route this membarrier fix through the scheduler maintainers, or is it OK to send it to you directly ?
Thanks, Mathieu ----- On Dec 15, 2017, at 2:23 PM, Mathieu Desnoyers [email protected] wrote: > smp_call_function_many requires disabling preemption around the call. > > Signed-off-by: Mathieu Desnoyers <[email protected]> > CC: Linus Torvalds <[email protected]> > CC: Peter Zijlstra <[email protected]> > CC: Paul E. McKenney <[email protected]> > CC: Boqun Feng <[email protected]> > CC: Andrew Hunter <[email protected]> > CC: Maged Michael <[email protected]> > CC: Avi Kivity <[email protected]> > CC: Benjamin Herrenschmidt <[email protected]> > CC: Paul Mackerras <[email protected]> > CC: Michael Ellerman <[email protected]> > CC: Dave Watson <[email protected]> > CC: Thomas Gleixner <[email protected]> > CC: Ingo Molnar <[email protected]> > CC: "H. Peter Anvin" <[email protected]> > CC: Andrea Parri <[email protected]> > CC: <[email protected]> # v4.14 > --- > kernel/sched/membarrier.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c > index dd7908743dab..9bcbacba82a8 100644 > --- a/kernel/sched/membarrier.c > +++ b/kernel/sched/membarrier.c > @@ -89,7 +89,9 @@ static int membarrier_private_expedited(void) > rcu_read_unlock(); > } > if (!fallback) { > + preempt_disable(); > smp_call_function_many(tmpmask, ipi_mb, NULL, 1); > + preempt_enable(); > free_cpumask_var(tmpmask); > } > cpus_read_unlock(); > -- > 2.11.0 -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com
