Hi Shawn, > -----Original Message----- > From: Shawn Guo [mailto:[email protected]] > Sent: Tuesday, December 26, 2017 5:09 PM > To: Peng Fan <[email protected]> > Cc: A.s. Dong <[email protected]>; [email protected]; Russell > King <[email protected]>; [email protected]; Sascha Hauer > <[email protected]>; Fabio Estevam <[email protected]>; linux- > [email protected] > Subject: Re: [PATCH] arm: imx: suspend/resume: use outer_disable/resume > > On Tue, Dec 26, 2017 at 06:52:45AM +0000, Peng Fan wrote: > > Hi Shawn, > > > > > -----Original Message----- > > > From: Shawn Guo [mailto:[email protected]] > > > Sent: Tuesday, December 26, 2017 11:31 AM > > > To: Peng Fan <[email protected]> > > > Cc: A.s. Dong <[email protected]>; [email protected]; > > > Russell King <[email protected]>; Fabio Estevam > > > <[email protected]>; Sascha Hauer <[email protected]>; > > > [email protected]; linux-arm- [email protected] > > > Subject: Re: [PATCH] arm: imx: suspend/resume: use > > > outer_disable/resume > > > > > > On Sun, Dec 10, 2017 at 08:07:18PM +0800, Peng Fan wrote: > > > > Use outer_disable/resume for suspend/resume. > > > > With the two APIs used, code could be simplified and easy to > > > > extend to introduce l2c_write_sec for i.MX platforms when moving > > > > Linux Kernel runs in non-secure world. > > > > > > > > Signed-off-by: Peng Fan <[email protected]> > > > > Cc: Shawn Guo <[email protected]> > > > > Cc: Sascha Hauer <[email protected]> > > > > Cc: Fabio Estevam <[email protected]> > > > > Cc: Russell King <[email protected]> > > > > Cc: Dong Aisheng <[email protected]> > > > > --- > > > > arch/arm/mach-imx/pm-imx6.c | 2 ++ > > > > arch/arm/mach-imx/suspend-imx6.S | 24 ------------------------ > > > > > > I'm fine with the patch in general. But this piece of code is > > > running on a few > > > i.MX6 platforms, and I'm wondering on which SoCs you have verified > > > the change work fine. > > > > I tested it on 6Q-SDB board. Is it ok? > > Okay, I will get it into linux-next for a bit wider testing.
Thanks. I missed to note that, I applied this patch in my testing https://www.spinics.net/lists/arm-kernel/msg623610.html to avoid suspicious RCU usage. Thanks, Peng. > > Shawn
