On Sun, Nov 19, 2017 at 12:04 PM, Geert Uytterhoeven <ge...@linux-m68k.org> wrote: > With gcc-4.1.2: > > drivers/thermal/hisi_thermal.c: In function ‘hisi_thermal_probe’: > drivers/thermal/hisi_thermal.c:530: warning: type qualifiers ignored on > function return type > > Remove the "const" keyword to fix this. > > Fixes: a160a465297362c5 ("thermal/drivers/hisi: Prepare to add support for > other hisi platforms") > Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org>
For future reference, this kind of warning shows up with gcc-4.2 as well, but not with gcc-4.3 or higher. I think in this case, both gcc and sparse fail to provide helpful feedback, but the code is probably better done using either a typedef for the function type, or with a structure containing the function pointer. Arnd