On Wed, 2018-01-10 at 17:16 +0900, Namhyung Kim wrote: > Hi Steve, > > On Wed, Jan 10, 2018 at 02:20:54AM -0500, Steven Rostedt wrote: > > On Wed, 10 Jan 2018 14:45:07 +0900 > > Namhyung Kim <[email protected]> wrote: > > > > > On Thu, Dec 21, 2017 at 10:02:22AM -0600, Tom Zanussi wrote: > > > > Hi, > > > > > > > > This is V8 of the inter-event tracing patchset, addressing input from > > > > V7. > > > > > > > > These changes address Namhyung's most recent comments (thanks, > > > > Namhyung!) and move everything to the latest tracing/for-next: > > > > > > > > - moved a couple hunks switching hist_field_fn_t params from 15/37 > > > > (add variable support) to 20/37 (Pass tracing_map_elt to > > > > hist_field_accessor) > > > > - in hist_trigger_elt_data_alloc(), remove the unnecessary '+1' from > > > > TASK_COMM_LEN size. > > > > - simplified find_var_file() code according to Namhyung's > > > > suggestions. > > > > - fixed bug in print_synth_event() where entry->fields was being > > > > used instead of the address as it should have been > > > > > > I only have a nitpick in the patch 24 but otherwise cannot find an > > > issue anymore, so > > > > > > Reviewed-by: Namhyung Kim <[email protected]> > > > > Thanks for reviewing this Namhyung. > > You're very welcome. >
Yes, thanks for the very thorough review, Namhyung. > > > > I'm currently traveling (what else is new?), and I want to start > > pulling this in. It wont be ready for the next merge window as it's too > > close, but I want to get it in by the one after that. I need to > > allocate some time to pull these patches in and review them as well. > > Yeah, I also would like to see it merged in v4.17. Have a nice travel > and take care. > I'll add these changes to a v9 along with another small nit found by the kbuild bot (parse_atom() can be static) and repost soon. Thanks, Tom
