On Thu, Jan 11, 2018 at 11:14:52AM +0100, Ahmed Abdelsalam wrote: > On Wed, 10 Jan 2018 16:32:24 +0100 > Pablo Neira Ayuso <[email protected]> wrote: > > > On Fri, Dec 29, 2017 at 12:08:25PM +0100, Ahmed Abdelsalam wrote: > > > This patch adds a new exetension to iptables to supprt 'srh' match > > > The implementation considers revision 7 of the SRH draft. > > > https://tools.ietf.org/html/draft-ietf-6man-segment-routing-header-07 > > > > > > Signed-off-by: Ahmed Abdelsalam <[email protected]> > > > --- > > > extensions/libip6t_srh.c | 283 > > > ++++++++++++++++++++++++++++++++ > > > include/linux/netfilter_ipv6/ip6t_srh.h | 63 +++++++ > > > > Please, add a extensions/libip6t_srh.t test file and send a v2. > > > > Thanks. > Ok, > Is there minimum requirements of the test cases to be added to the > extensions/libip6t_srh.t file ?
I leave it up to you to decide what level of coverage you consider is good to make sure that future changes don't break your new feature. Thanks!
