On Thu, Jan 11, 2018 at 05:58:11PM -0800, Dave Hansen wrote:
> On 01/11/2018 05:32 PM, Ashok Raj wrote:
> > +static void save_guest_spec_ctrl(struct vcpu_vmx *vmx)
> > +{
> > + if (boot_cpu_has(X86_FEATURE_SPEC_CTRL)) {
> > + vmx->spec_ctrl = spec_ctrl_get();
> > + spec_ctrl_restriction_on();
> > + } else
> > + rmb();
> > +}
>
> Does this need to be "ifence()"? Better yet, do we just need to create
> a helper for boot_cpu_has(X86_FEATURE_SPEC_CTRL) that does the barrier?
Yes... Didn't keep track of ifence() evolution :-)..
We could do a helper, will look into other uses and see we can make find a
common way to comprehend usages like above.
Cheers,
Ashok
