On Fri, Jan 12, 2018 at 04:37:15PM +0000, Colin King wrote: > From: Colin Ian King <[email protected]> > > It appears that the check for versions 4 or more is incorrect and is > off-by-one. Fix this. > > Detected by CoverityScan, CID#1463775 ("Logically dead code") > > Fixes: ac503a4cc9e8 ("xfs: refactor the geometry structure filling function") > Signed-off-by: Colin Ian King <[email protected]>
Looks ok, Reviewed-by: Darrick J. Wong <[email protected]> > --- > fs/xfs/libxfs/xfs_sb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c > index 35b005d66977..869a2f3f0375 100644 > --- a/fs/xfs/libxfs/xfs_sb.c > +++ b/fs/xfs/libxfs/xfs_sb.c > @@ -951,7 +951,7 @@ xfs_fs_geometry( > geo->rtsectsize = sbp->sb_blocksize; > geo->dirblocksize = xfs_dir2_dirblock_bytes(sbp); > > - if (struct_version < 3) > + if (struct_version < 4) > return 0; > > if (xfs_sb_version_haslogv2(sbp)) > -- > 2.15.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to [email protected] > More majordomo info at http://vger.kernel.org/majordomo-info.html
