[Please do not top post. I also think you didn't intend to drop the CC list - restored]
On Tue 16-01-18 03:13:31, Robert Rickett wrote: > Michal, > > Although tiny changes like this are minuscule, they are relevant to the > big picture. If developers create a tool that informs contributors of an > error in the code, but then says "I'm aware of the error, but it's not > worth fixing", what's the point of programming the tool to warn the end-user > in the first place? Why not just say "We want you to use tabs, but it's > okay not to if you don't feel like it"? Either way, Thank You for taking > the time to respond and have a great day! > > Robert > Rickett > > > On Tue, Jan 16, 2018 at 1:46 AM, Michal Hocko <[email protected]> wrote: > > > On Mon 15-01-18 19:17:12, Robert Donald Rickett wrote: > > > This is a patch to the memory.c file that fixes the > > > "ERROR: code indent should use tabs where possible" > > > found by the checkpatch.pl tool. > > > > Is this really worth it? The code is not any better readable and it just > > adds a churn to the history and makes life of anybody using git blame > > slightly more harder. So what is the benefit? > > > > > Signed-off-by: Robert Donald Rickett <[email protected]> > > > --- > > > mm/memory.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mm/memory.c b/mm/memory.c > > > index ca5674cbaff2..e9f6e58aa77c 100644 > > > --- a/mm/memory.c > > > +++ b/mm/memory.c > > > @@ -1663,7 +1663,7 @@ int zap_vma_ptes(struct vm_area_struct *vma, > > unsigned long address, > > > unsigned long size) > > > { > > > if (address < vma->vm_start || address + size > vma->vm_end || > > > - !(vma->vm_flags & VM_PFNMAP)) > > > + !(vma->vm_flags & VM_PFNMAP)) > > > return -1; > > > zap_page_range_single(vma, address, size, NULL); > > > return 0; > > > -- > > > 2.14.1 > > > > -- > > Michal Hocko > > SUSE Labs > > -- Michal Hocko SUSE Labs
