Hi Tony,

On Mon, 2018-01-15 at 17:11 -0800, Tony Lindgren wrote:
> We can support the RSTCTRL reset registers on many TI SoCs with
> reset-simple.
> 
> Cc: Dave Gerlach <d-gerl...@ti.com>
> Cc: Mark Rutland <mark.rutl...@arm.com>
> Cc: Nishant Menon <n...@ti.com>
> Cc: Philipp Zabel <p.za...@pengutronix.de>
> Cc: Rob Herring <robh...@kernel.org>
> Cc: Suman Anna <s-a...@ti.com>
> Cc: Tero Kristo <t-kri...@ti.com>
> Signed-off-by: Tony Lindgren <t...@atomide.com>
> ---
> 
> That's all there is to it :) Naturally this can wait for v4.17
> if necessary.
> 
> ---
>  .../devicetree/bindings/reset/ti-rstctrl.txt       | 29 
> ++++++++++++++++++++++
>  drivers/reset/Kconfig                              |  2 +-
>  drivers/reset/reset-simple.c                       |  1 +
>  3 files changed, 31 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/devicetree/bindings/reset/ti-rstctrl.txt
> 
> diff --git a/Documentation/devicetree/bindings/reset/ti-rstctrl.txt 
> b/Documentation/devicetree/bindings/reset/ti-rstctrl.txt
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/ti-rstctrl.txt
> @@ -0,0 +1,29 @@
> +TI RSTCTRL Reset Controller
> +
> +Required properties:
> +- compatible : "ti,rstctrl"
> +- reg : Should contain 1 register ranges(address and length)
> +- #reset-cells: 1
> +
> +Example:
> +
> +     prcm: prcm@200000 {
> +             compatible = "ti,am3-prcm", "simple-bus";
> +             reg = <0x200000 0x4000>;
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             ranges = <0 0x200000 0x4000>;
> +
> +             prm_gfx: prm@1100 {
> +                     compatible = "simple-bus";
> +                     #address-cells = <1>;
> +                     #size-cells = <1>;
> +                     ranges = <0 0x1100 0x100>;
> +
> +                     gfx_rstctrl: rstctrl@4 {
                        ,->
> +                     |       reg = <0x4 0x4>;
> +                     |       #reset-cells = <1>;
> +                     `--     compatible = "ti,rstctrl";

Looks good to me. Can I move the compatible property when applying?

> +                     };
> +             };
> +     };
> diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
> --- a/drivers/reset/Kconfig
> +++ b/drivers/reset/Kconfig
> @@ -83,7 +83,7 @@ config RESET_PISTACHIO
>  
>  config RESET_SIMPLE
>       bool "Simple Reset Controller Driver" if COMPILE_TEST
> -     default ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || 
> ARCH_ZX
> +     default ARCH_OMAP2PLUS || ARCH_SOCFPGA || ARCH_STM32 || ARCH_STRATIX10 
> || ARCH_SUNXI || ARCH_ZX
>       help
>         This enables a simple reset controller driver for reset lines that
>         that can be asserted and deasserted by toggling bits in a contiguous,
> diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c
> --- a/drivers/reset/reset-simple.c
> +++ b/drivers/reset/reset-simple.c
> @@ -123,6 +123,7 @@ static const struct of_device_id reset_simple_dt_ids[] = {
>       { .compatible = "st,stm32-rcc", },
>       { .compatible = "allwinner,sun6i-a31-clock-reset",
>               .data = &reset_simple_active_low },
> +     { .compatible = "ti,rstctrl", },
>       { .compatible = "zte,zx296718-reset",
>               .data = &reset_simple_active_low },
>       { /* sentinel */ },

regards
Philipp

Reply via email to