Hi, On Tue, Jan 09, 2018 at 05:09:17PM +0100, Johan Hovold wrote: > Only serdev devices (a.k.a. clients or slaves) are bound to drivers so > bail out early from match() in case the device is not a serdev device > (i.e. if it's a serdev controller). > > Signed-off-by: Johan Hovold <[email protected]> > ---
Reviewed-by: Sebastian Reichel <[email protected]> -- Sebastian > drivers/tty/serdev/core.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c > index c8c43834477b..f710862f5c06 100644 > --- a/drivers/tty/serdev/core.c > +++ b/drivers/tty/serdev/core.c > @@ -63,6 +63,11 @@ static const struct device_type serdev_device_type = { > .release = serdev_device_release, > }; > > +static bool is_serdev_device(const struct device *dev) > +{ > + return dev->type == &serdev_device_type; > +} > + > static void serdev_ctrl_release(struct device *dev) > { > struct serdev_controller *ctrl = to_serdev_controller(dev); > @@ -76,6 +81,9 @@ static const struct device_type serdev_ctrl_type = { > > static int serdev_device_match(struct device *dev, struct device_driver *drv) > { > + if (!is_serdev_device(dev)) > + return 0; > + > /* TODO: platform matching */ > if (acpi_driver_match_device(dev, drv)) > return 1; > -- > 2.15.1 >
signature.asc
Description: PGP signature
