Re: [PATCH v17 06/10] drm/tinydrm: Call devres version of of_find_backlight

[Noralf Trønnes]

Den 19.01.2018 11.46, skrev Meghana Madhyastha:

Call devm_of_find_backlight (the devres version) instead of
of_find_backlight.

Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com>
---

I already put my r-b on this one in the previous version, but now also:

Tested-by: Noralf Trønnes <nor...@tronnes.org>

I did also test with the backlight subsystem disabled.

changes in v17:
-convert st7735r callers from tinydrm specific helpers
  to new generic backlight helpers

  drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +-
  drivers/gpu/drm/tinydrm/st7735r.c  | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c 
b/drivers/gpu/drm/tinydrm/mi0283qt.c
index a8aafce36..d8ed6e6f8 100644
--- a/drivers/gpu/drm/tinydrm/mi0283qt.c
+++ b/drivers/gpu/drm/tinydrm/mi0283qt.c
@@ -196,7 +196,7 @@ static int mi0283qt_probe(struct spi_device *spi)
        if (IS_ERR(mipi->regulator))
                return PTR_ERR(mipi->regulator);

- mipi->backlight = of_find_backlight(dev);

+       mipi->backlight = devm_of_find_backlight(dev);
        if (IS_ERR(mipi->backlight))
                return PTR_ERR(mipi->backlight);

diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tinydrm/st7735r.c

index 2e6b7b8ec..67d197ecf 100644
--- a/drivers/gpu/drm/tinydrm/st7735r.c
+++ b/drivers/gpu/drm/tinydrm/st7735r.c
@@ -164,7 +164,7 @@ static int st7735r_probe(struct spi_device *spi)
                return PTR_ERR(dc);
        }

- mipi->backlight = of_find_backlight(dev);

+       mipi->backlight = devm_of_find_backlight(dev);
        if (IS_ERR(mipi->backlight))
                return PTR_ERR(mipi->backlight);