On Tue, 2018-01-23 at 20:21 +0800, Dong Aisheng wrote: > > In a more general way, I'd love to see a feature such as > > CLK_DIVIDER_ZERO_GATE > > added to the divider but I'm bit concerned of all the quirks we are slowly > > adding to the generic divider. It seems we are all trying re-use the > > algorithm > > of clk_divider_bestdiv() with different 'val-to-div' transfer function. Not > > too > > sure what the best solution could be though. > > > > IMHO CLK_DIVIDER_ZERO_GATE only indicates the 0 val means clk gate. > It does not assume divider types. That looks like a generic way and is exactly > what this patch intends to do. Does it make sense?
It makes sense. That last comment was not about your patch specifically but about the growing entropy in clk-divider.c in general.

