From: Markus Elfring <[email protected]> Date: Thu, 25 Jan 2018 19:20:38 +0100
Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/input/misc/ims-pcu.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index 4aca2a02ff6d..d7778b273151 100644 --- a/drivers/input/misc/ims-pcu.c +++ b/drivers/input/misc/ims-pcu.c @@ -288,12 +288,10 @@ static void ims_pcu_gamepad_report(struct ims_pcu *pcu, u32 data) static int ims_pcu_setup_gamepad(struct ims_pcu *pcu) { - struct ims_pcu_gamepad *gamepad; - struct input_dev *input; int error; + struct ims_pcu_gamepad *gamepad = kzalloc(sizeof(*gamepad), GFP_KERNEL); + struct input_dev *input = input_allocate_device(); - gamepad = kzalloc(sizeof(struct ims_pcu_gamepad), GFP_KERNEL); - input = input_allocate_device(); if (!gamepad || !input) { dev_err(pcu->dev, "Not enough memory for gamepad device\n"); @@ -2003,10 +2001,9 @@ static int ims_pcu_probe(struct usb_interface *intf, const struct usb_device_id *id) { struct usb_device *udev = interface_to_usbdev(intf); - struct ims_pcu *pcu; int error; + struct ims_pcu *pcu = kzalloc(sizeof(*pcu), GFP_KERNEL); - pcu = kzalloc(sizeof(struct ims_pcu), GFP_KERNEL); if (!pcu) return -ENOMEM; -- 2.16.1
