After checking all possible call chains to mtip_handle_tfe() here, my tool finds that this function is never called in atomic context, namely never in an interrupt handler or holding a spinlock. And mtip_handle_tfe() is only called by mtip_service_thread() that can sleep as described in the last patch, so it indicates that mtip_handle_tfe() can call functions that can sleep. Thus mdelay can be replaced with msleep to avoid busy wait.
This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai <[email protected]> --- drivers/block/mtip32xx/mtip32xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index b8af735..b302167 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -604,7 +604,7 @@ static void mtip_handle_tfe(struct driver_data *dd) print_tags(dd, "completed (TFE)", tagaccum, cmd_cnt); /* Restart the port */ - mdelay(20); + msleep(20); mtip_restart_port(port); /* Trying to determine the cause of the error */ -- 1.7.9.5
