On Mon, May 21, 2007 at 12:58:03PM +0200, Ingo Molnar wrote: > and nobody pushed strong enough to get it included. But ... Peter's > patch could perhaps be extended to cover similar stats as lockmeter, > ontop of the existing lockdep instrumentation. Peter, can you see any > particular roadblocks with that?
Definitely. Lockmeter isn't terribly Linux-ish from my examination of that patch a while back. Doing it against lockdep is definitely the right thing to do in that it unifies lock handling through initializer keys that lockmeter doesn't, from my memory. The spin time tracking can be put into the slow path of the spin, like what peter has now, so that it has minimal impact against the uncontended case. Updating the times would then be a trivial pointer dereference plus add and hopefully won't have instrumentation side effects against the rest of the locking behavior in the system. bill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
