On 01/02/18 17:24, SF Markus Elfring wrote:
> Omit an extra message for a memory allocation failure in this function.
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>

Reviewed-by: Alexander Sverdlin <alexander.sverd...@nokia.com>

> ---
>  drivers/i2c/muxes/i2c-mux-reg.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c
> index c948e5a4cb04..f624ed64a47b 100644
> --- a/drivers/i2c/muxes/i2c-mux-reg.c
> +++ b/drivers/i2c/muxes/i2c-mux-reg.c
> @@ -127,10 +127,8 @@ static int i2c_mux_reg_probe_dt(struct regmux *mux,
>       values = devm_kzalloc(&pdev->dev,
>                             sizeof(*mux->data.values) * mux->data.n_values,
>                             GFP_KERNEL);
> -     if (!values) {
> -             dev_err(&pdev->dev, "Cannot allocate values array");
> +     if (!values)
>               return -ENOMEM;
> -     }
>  
>       for_each_child_of_node(np, child) {
>               of_property_read_u32(child, "reg", values + i);

-- 
Best regards,
Alexander Sverdlin.

Reply via email to