Jiri, On Thu, Feb 1, 2018 at 12:38 AM, Jiri Olsa <jo...@kernel.org> wrote: > Stephane reported that we don't set properly PERIOD > sample type for events with period term defined. > > Before: > $ perf record -e cpu/cpu-cycles,period=1000/u ls > $ perf evlist -v > cpu/cpu-cycles,period=1000/u: ... sample_type: IP|TID|TIME|PERIOD, ... > > After: > $ perf record -e cpu/cpu-cycles,period=1000/u ls > $ perf evlist -v > cpu/cpu-cycles,period=1000/u: ... sample_type: IP|TID|TIME, ... > > Setting PERIOD sample type based on period term setup. > there is still one problem remaining here. It has to do with the handling of cycles:pp or :p or :ppp. Suppose I want to set a period for it while I am also sampling on other events: Something like:
$ perf record -e cycles:pp,instructions,cpu/event=0xd0,umaks=0x81,period=100000/ ..... I want to set the period for cycles:pp, but not for instructions. I cannot use -c because it would also force a period on instructions. I could use the raw hw raw event code for cycles:pp. But that does not work because recent kernels prevent use of hw filters on events programmed for PEBS, e.g., cpu/event=0xc2,umask=0x1,cmask=16,inv/pp is rejected. PEBS does not support filters. It works in the case of cycles:pp simply by the nature on the underlying event and the stalls. To get precise cycles, the only event syntax you can use is cycles:pp, but then you cannot specify an event-specific period. This needs to be fixed as well. I'd like to be able to say: $ perf record -e cycles:pp:period=10000001,cpu/event=0xd0,umaks=0x81,period=100000/ Or something equivalent. Otherwise, I tested what you have written so far and it works. Thanks. > Reported-by: Stephane Eranian <eran...@google.com> > Link: http://lkml.kernel.org/n/tip-anrtntkwfto5rqulegfwi...@git.kernel.org > Signed-off-by: Jiri Olsa <jo...@kernel.org> > --- > tools/perf/util/evsel.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 66fa45198a11..f2f2eaafde6d 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -745,12 +745,14 @@ static void apply_config_terms(struct perf_evsel *evsel, > if (!(term->weak && opts->user_interval != > ULLONG_MAX)) { > attr->sample_period = term->val.period; > attr->freq = 0; > + perf_evsel__reset_sample_bit(evsel, PERIOD); > } > break; > case PERF_EVSEL__CONFIG_TERM_FREQ: > if (!(term->weak && opts->user_freq != UINT_MAX)) { > attr->sample_freq = term->val.freq; > attr->freq = 1; > + perf_evsel__set_sample_bit(evsel, PERIOD); > } > break; > case PERF_EVSEL__CONFIG_TERM_TIME: > -- > 2.13.6 >
