From: Markus Elfring <[email protected]> Date: Tue, 6 Feb 2018 16:48:52 +0100
Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> --- drivers/hid/hid-lenovo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c index 1ac4ff4d57a6..549b84d01b46 100644 --- a/drivers/hid/hid-lenovo.c +++ b/drivers/hid/hid-lenovo.c @@ -688,7 +688,6 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev) sizeof(struct lenovo_drvdata_tpkbd), GFP_KERNEL); if (data_pointer == NULL) { - hid_err(hdev, "Could not allocate memory for driver data\n"); ret = -ENOMEM; goto err; } @@ -746,10 +745,9 @@ static int lenovo_probe_cptkbd(struct hid_device *hdev) cptkbd_data = devm_kzalloc(&hdev->dev, sizeof(*cptkbd_data), GFP_KERNEL); - if (cptkbd_data == NULL) { - hid_err(hdev, "can't alloc keyboard descriptor\n"); + if (!cptkbd_data) return -ENOMEM; - } + hid_set_drvdata(hdev, cptkbd_data); /* -- 2.16.1
