Em Tue, Feb 06, 2018 at 07:18:02PM +0100, Jiri Olsa escreveu: > Adding check on failed attempt to parse the address > and skip the line parsing early in that case.
How did you stumble on that? Can you provide an example of a line or situation where this would happen? - Arnaldo > Link: http://lkml.kernel.org/n/[email protected] > Signed-off-by: Jiri Olsa <[email protected]> > --- > tools/lib/symbol/kallsyms.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/tools/lib/symbol/kallsyms.c b/tools/lib/symbol/kallsyms.c > index 914cb8e3d40b..689b6a130dd7 100644 > --- a/tools/lib/symbol/kallsyms.c > +++ b/tools/lib/symbol/kallsyms.c > @@ -38,6 +38,10 @@ int kallsyms__parse(const char *filename, void *arg, > > len = hex2u64(line, &start); > > + /* Skip the line if we failed to parse the address. */ > + if (!len) > + continue; > + > len++; > if (len + 2 >= line_len) > continue; > -- > 2.13.6
