On 02/07/18 at 01:48pm, Eric W. Biederman wrote:
> ebied...@xmission.com (Eric W. Biederman) writes:

> > Now that I see that I agree in essence with this patch series.
> > I don't agree with the implemenation details.
> >
> > Can you please split disable_IO_APIC and switch_to_legacy_irq_mode
> > in a single patch.
> 
> Now that I think about it can you call the function not
> switch_to_legacy_irq_mode but restore_boot_irq_mode.  And the
> corresponding x86_io_apic_ops not .disable but .restore.
> 
> That should make the purpose of the code clearer, and help avoid
> mistakes like the one that led to this regression.

Thanks for your comments and great suggestion. Have made change as you
suggested, will post after test passed.

Thanks
Baoquan

Reply via email to