On (02/09/18 13:11), Mike Rapoport wrote: [..] > > +/** > > + * zs_huge_object() - Test if a compressed object's size is too big for > > normal > > + * zspool classes and it will be stored in a huge class. > > Maybe "it should be stored ..."?
Agreed. > > + * @sz: Size in bytes of the compressed object. > > + * > > + * The functions checks if the object's size falls into huge_class area. > > + * We must take ZS_HANDLE_SIZE into account and test the actual size we > > ^ %ZS_HANDLE_SIZE Indeed. ``%CONST`` > > + * are going to use up, because zs_malloc() unconditionally adds the > > I think 's/use up/use/' here Agreed. > > + * handle size before it performs size_class lookup. > > ^ &size_class OK. ``&struct name`` Thanks for reviewing it! -ss