On Mon, Feb 12, 2018 at 08:43:58PM +0200, Sagi Grimberg wrote:
> > Currently, we will unquiesce the queues after the controller is
> > shutdown to avoid residual requests to be stuck. In fact, we can
> > do it more cleanly, just wait freeze and drain the queue in
> > nvme_dev_disable and finally leave the queues quiesced.
> Does this fix a bug? What is the benefit of leaving the queues
> quiesced in shutdown?
This doesn't appear to fix anything. The things this patch does do are
either unnecessary (quiece), or already done elsewhere (wait freeze).