On Mon, Feb 12, 2018 at 3:37 PM, Himanshu Jha <himanshujha199...@gmail.com> wrote: > On Mon, Feb 12, 2018 at 03:10:56PM +0100, Philippe Ombredanne wrote: >> On Mon, Feb 12, 2018 at 12:54 PM, Himanshu Jha >> <himanshujha199...@gmail.com> wrote: >> > Move the adis16201 driver out of staging directory and merge to the >> > mainline IIO directory. >> > >> > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> >> >> <snip> >> > --- /dev/null >> > +++ b/drivers/iio/accel/adis16201.c >> > @@ -0,0 +1,315 @@ >> > +// SPDX-License-Identifier: GPL-2.0+ >> >> <snip> >> >> > +MODULE_AUTHOR("Barry Song <21cn...@gmail.com>"); >> > +MODULE_DESCRIPTION("Analog Devices ADIS16201 Dual-Axis Digital >> > Inclinometer and Accelerometer"); >> > +MODULE_LICENSE("GPL v2"); >> > +MODULE_ALIAS("spi:adis16201"); >> >> Your MODULE_LICENSE does not match your SPDX license id. >> MODULE_LICENSE("GPL v2"); means SPDX GPL-2.0 >> MODULE_LICENSE("GPL"); means SPDX GPL-2.0+ >> > > I didn't knew about that! Thanks for pointing.
Sure thing. I reckon this can be a tad surprising. FWIW, the reference for the SPDX tag is in Documentation/process/license-rules.rst and for the MODULE_LICENSE macro this is in module.h It is unlikely module.h will ever evolve there as this would break all third-party module loaders/tools that rely on the documented data values and conventions -- Cordially Philippe Ombredanne