On Mon, Feb 12, 2018 at 02:17:12PM +0100, Linus Walleij wrote:
> Instead of passing a global GPIO number for the enable GPIO, pass
> a descriptor looked up from the device tree node or the board file
> decriptor table for the regulator.
> 
> There is a single board file passing the GPIOs for LDO1 and LDO2
> through platform data, so augment this to pass descriptors
> associated with the i2c device as well.
> 
> Cc: patc...@opensource.cirrus.com
> Cc: Charles Keepax <ckee...@opensource.cirrus.com>
> Cc: Lee Jones <lee.jo...@linaro.org>
> Signed-off-by: Linus Walleij <linus.wall...@linaro.org>
> ---
> +     /* Look up LDO enable GPIO from the parent device node */
> +     gpiod = devm_gpiod_get_optional(pdev->dev.parent,
> +                                     id ? "wlf,ldo2ena" : "wlf,ldo1ena",
> +                                     GPIOD_OUT_LOW);
> +     if (IS_ERR(gpiod))
> +             return PTR_ERR(gpiod);
> +     config.ena_gpiod = gpiod;

Likewise here the DT bindings for these parts have no -gpio
suffix on them so this will break the DT case.

Thanks,
Charles

Reply via email to