Re: [PATCH v2 07/15] MIPS: memblock: Reserve kdump/crash regions in memblock

[Matt Redfearn]

Hi Serge,

On 02/02/18 03:54, Serge Semin wrote:

Kdump/crashkernel memory regions should be reserved in the
memblock allocator so they wouldn't be occupied by any further
allocations.

Signed-off-by: Serge Semin <fancer.lan...@gmail.com>

This looks good to me

Reviewed-by: Matt Redfearn <matt.redfe...@mips.com>

Thanks,
Matt

---
  arch/mips/kernel/setup.c | 8 +++-----
  1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/arch/mips/kernel/setup.c b/arch/mips/kernel/setup.c
index 72853e94c2c7..b2a5b89ae6b2 100644
--- a/arch/mips/kernel/setup.c
+++ b/arch/mips/kernel/setup.c
@@ -826,17 +826,15 @@ static void __init arch_mem_init(char **cmdline_p)
        if (setup_elfcorehdr && setup_elfcorehdr_size) {
                printk(KERN_INFO "kdump reserved memory at %lx-%lx\n",
                       setup_elfcorehdr, setup_elfcorehdr_size);
-               reserve_bootmem(setup_elfcorehdr, setup_elfcorehdr_size,
-                               BOOTMEM_DEFAULT);
+               memblock_reserve(setup_elfcorehdr, setup_elfcorehdr_size);
        }
  #endif

mips_parse_crashkernel();

  #ifdef CONFIG_KEXEC
        if (crashk_res.start != crashk_res.end)
-               reserve_bootmem(crashk_res.start,
-                               crashk_res.end - crashk_res.start + 1,
-                               BOOTMEM_DEFAULT);
+               memblock_reserve(crashk_res.start,
+                                crashk_res.end - crashk_res.start + 1);
  #endif
        device_tree_init();
        sparse_init();