On Tue, 13 Feb 2018, Alan Cox wrote: > > if (c->x86_cache_size >= 0) > > seq_printf(m, "cache size\t: %d KB\n", c->x86_cache_size); > > > > which is silly, because that really can be done with: > > > > if (c->x86_cache_size) > > > > as there is no point in printing 'cache size 0KB', which means > > x86_cache_size can be made unsigned int, which makes sense because cache > > size < 0 does not at all. > > Currently 0MB means "I know you have no cache" (early slot 1 celeron), > while not printing it means 'I have no clue'
Cute. I hope the 3 slot1 celeron users will not go wild if their /proc/cpuinfo now claims to have no clue about caches. Thanks, tglx