On Fri, 2018-02-16 at 21:28 +0200, Andy Shevchenko wrote: > Sparse complains that constant is so bit for unsigned long on 64-bit > architecture. > > lib/test_printf.c:217:54: warning: constant 0xffff0123456789ab is so > big it is unsigned long > lib/test_printf.c:246:54: warning: constant 0xffff0123456789ab is so > big it is unsigned long > > To satisfy everyone, mark the constant with ULL. >
Please, drop entire series. I found more candidates inside the file which can utilize changes. Besides that, there is a typo in commit message of patch 3. > Signed-off-by: Andy Shevchenko <[email protected]> > --- > lib/test_printf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 71ebfa43ad05..309cf8d7e6d4 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -204,7 +204,7 @@ test_string(void) > #if BITS_PER_LONG == 64 > > #define PTR_WIDTH 16 > -#define PTR ((void *)0xffff0123456789ab) > +#define PTR ((void *)0xffff0123456789abULL) > #define PTR_STR "ffff0123456789ab" > #define ZEROS "00000000" /* hex 32 zero bits */ > -- Andy Shevchenko <[email protected]> Intel Finland Oy
