Hi,

On 19-02-18 14:47, Andy Shevchenko wrote:
On Mon, Feb 19, 2018 at 12:01 AM, Hans de Goede <hdego...@redhat.com> wrote:
The value returned by sst_prepare_and_post_msg() is a negated SST_ERR_*
value, so we must check for -SST_ERR_INVALID_STREAM_ID. Note that
sst_pause_resume() already has the correct check.


Should it have Fixes tag?

According to git blame this goes back to the original commit introducing
the file, so I don't think that that is helpful.

Regards,

Hans




Signed-off-by: Hans de Goede <hdego...@redhat.com>
---
  sound/soc/intel/atom/sst/sst_stream.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst/sst_stream.c 
b/sound/soc/intel/atom/sst/sst_stream.c
index 7ee6aeb7e0af..b082b0922a7a 100644
--- a/sound/soc/intel/atom/sst/sst_stream.c
+++ b/sound/soc/intel/atom/sst/sst_stream.c
@@ -253,7 +253,7 @@ int sst_pause_stream(struct intel_sst_drv *sst_drv_ctx, int 
str_id)
                 if (retval == 0) {
                         str_info->prev = str_info->status;
                         str_info->status = STREAM_PAUSED;
-               } else if (retval == SST_ERR_INVALID_STREAM_ID) {
+               } else if (retval == -SST_ERR_INVALID_STREAM_ID) {
                         retval = -EINVAL;
                         mutex_lock(&sst_drv_ctx->sst_lock);
                         sst_clean_stream(str_info);
--
2.14.3




Reply via email to