On 02/21/2018 08:31 PM, Simon Horman wrote:
>>>>> Populate the ethernet@e6800000 device node to enable Ethernet interface
>>>>> for R-Car M3-N (r8a77965) SoC.
>>>>>
>>>>> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
>>>>> Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be>
>>>>>
>>>>> ---
>>>>> v1 -> v2:
>>>>> - Replace ALWAYS_ON power area identifier with numeric constant
>>>>> ---
>>>>> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 43
>>>>> ++++++++++++++++++++++++++++++-
>>>>> 1 file changed, 42 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>> index 55f05f7..c249895 100644
>>>>> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
>>>>> @@ -520,7 +520,48 @@
>>>>> };
>>>>>
>>>>> avb: ethernet@e6800000 {
>>>>> - /* placeholder */
>>>>> + compatible = "renesas,etheravb-r8a77965",
>>>>> + "renesas,etheravb-rcar-gen3";
>>>>> + reg = <0 0xe6800000 0 0x800>, <0 0xe6a00000 0 0x10000>;
>>>>> + interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 46 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 54 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>,
>>>>> + <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
>>>>> + interrupt-names = "ch0", "ch1", "ch2", "ch3",
>>>>> + "ch4", "ch5", "ch6", "ch7",
>>>>> + "ch8", "ch9", "ch10", "ch11",
>>>>> + "ch12", "ch13", "ch14", "ch15",
>>>>> + "ch16", "ch17", "ch18", "ch19",
>>>>> + "ch20", "ch21", "ch22", "ch23",
>>>>> + "ch24";
>>>>> + clocks = <&cpg CPG_MOD 812>;
>>>>> + power-domains = <&sysc 32>;
>>>>> + resets = <&cpg 812>;
>>>>> + phy-mode = "rgmii-txid";
>>>>
>>>> Why not just "rgmii"? TX delay is a board specific detail, no?
>>>>
>>> I admit I took this one straight from r8a7796 dtsi.
>>> Would you like to me resend and change this?
>>
>> Yes, unless Simon would fix it while merging...
>
> Can I confirm the desired change is s/rgmii-txid/rgmii/ ?
Yes.
> If so I can fix that up.
Thank you!
MBR, Sergei
