On Thu, 22 Feb 2018 19:08:29 +0200
Andy Shevchenko <andy.shevche...@gmail.com> wrote:

> On Thu, Feb 22, 2018 at 6:31 PM, Shreeya Patel
> <shreeya.patel23...@gmail.com> wrote:
> > Using pr_<loglevel>() is more concise than
> > printk(KERN_<LOGLEVEL>).
> > Replace printks having a log level with the appropriate
> > pr_*() macros.
> > Define pr_fmt() and remove other additional macros from
> > the replaced printks.  
> 
> It makes sense to fix indentation, like in case similar to ' mm?"":""
> ',

Fix indentation if you change the line, why not...

> and fix the specifiers, when
> void *p is printed as 0x%08x or alike.

But specifier fixes should be done separately, and I'm not sure I
want to receive yet another bunch of cosmestic patches changing that, at
least not now.

-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

Reply via email to