On Fri, Feb 23, 2018 at 05:22:55PM +0100, Robin Jarry wrote:
> 2018-02-23, Josh Poimboeuf:
> > Hi Robin,
> > 
> > Did you test this?  I see some issues:
> > 
> > a) I don't see where the host_cflags variable comes from (and btw, it's
> >    misspelled...)
> 
> Hi Josh,
> 
> Shame on me... Last minute fix. I had tested this first by forcing
> HOSTCC="gcc <CFLAGS> <LDFLAGS>" but I found it rather dirty. As it turns
> out, my patch is not better.
> 
> > b) I don't see where objtool uses HOSTLDFLAGS.
> 
> Indeed, I also missed this (see above).
> 
> It looks like objtool does not use HOSTCFLAGS nor HOSTLDFLAGS (defined
> in top Makefile). Do you see a reason why? Maybe it would be a good idea
> to share these flags (adding some specific ones for objtool, if needed).
> 
> What do you think?

Yeah, I think it would be a good idea for objtool to use HOSTCC,
HOSTCFLAGS, and HOSTLDFLAGS.

-- 
Josh

Reply via email to