On Sat, Feb 24, 2018 at 07:30:44PM +0100, Borislav Petkov wrote:
>
> And, for the record, if we have to break a function signature, we align the
> arguments at the opening brace like this:
>
> static inline int __must_check kstrtou64_from_user(const char __user *s,
> size_t count, unsigned int
> base, u64 *res)
>
An alternate approach is this:
static inline int __must_check
kstrtou64_from_user(const char __user *s, size_t count, unsigned int base, u64
*res)
Which yes, is still longer than 80 characters. But this is where
blindly following coding guidelines as if they are fundamentalist
biblical doctrine is not really a great idea. The goal is to make the
code easier to read, and very often it's important to apply _judgement_.
(Which is one of the reasons why I generally don't really like newbies
trying to apply checkpatch.pl to existing source files.)
Cheers,
- Ted
