On Fri 23-02-18 16:43:37, Dan Williams wrote:
> Do not bother looking up the file type in the case when Filesystem-DAX
> is disabled at build time.
> 
> Cc: Alexander Viro <v...@zeniv.linux.org.uk>
> Cc: linux-fsde...@vger.kernel.org
> Cc: Christoph Hellwig <h...@lst.de>
> Cc: Jan Kara <j...@suse.cz>
> Signed-off-by: Dan Williams <dan.j.willi...@intel.com>

Looks good. You can add:

Reviewed-by: Jan Kara <j...@suse.cz>

                                                                Honza

> ---
>  include/linux/fs.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 7418341578a3..c97fc4dbaae1 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -3197,6 +3197,8 @@ static inline bool vma_is_fsdax(struct vm_area_struct 
> *vma)
>  
>       if (!vma->vm_file)
>               return false;
> +     if (!IS_ENABLED(CONFIG_FS_DAX))
> +             return false;
>       if (!vma_is_dax(vma))
>               return false;
>       inode = file_inode(vma->vm_file);
> 
-- 
Jan Kara <j...@suse.com>
SUSE Labs, CR

Reply via email to