From: Antoine Tenart <[email protected]> Date: Mon, 26 Feb 2018 15:14:26 +0100
> From: Yan Markman <[email protected]> > > Adjust MVPP2_MAX_TSO_SEGS and stop_threshold/wake_threshold > for better TXQ utilization and performance. > > Signed-off-by: Yan Markman <[email protected]> > --- > drivers/net/ethernet/marvell/mvpp2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 55300b1fe6c0..1a893ef70eab 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++ b/drivers/net/ethernet/marvell/mvpp2.c > @@ -498,7 +498,7 @@ > * skb. As we need a maxium of two descriptors per fragments (1 header, 1 > data), > * multiply this value by two to count the maximum number of skb descs > needed. > */ > -#define MVPP2_MAX_TSO_SEGS 300 > +#define MVPP2_MAX_TSO_SEGS 100 > #define MVPP2_MAX_SKB_DESCS (MVPP2_MAX_TSO_SEGS * 2 + MAX_SKB_FRAGS) > > /* Dfault number of RXQs in use */ > @@ -5810,7 +5810,7 @@ static int mvpp2_txq_init(struct mvpp2_port *port, > txq_pcpu->tso_headers = NULL; > > txq_pcpu->stop_threshold = txq->size - MVPP2_MAX_SKB_DESCS; > - txq_pcpu->wake_threshold = txq_pcpu->stop_threshold / 2; > + txq_pcpu->wake_threshold = txq_pcpu->stop_threshold - 100; > This number 100 is a magic constant. If it is related to MVPP2_MAX_TSO_SEGS, please use that define. Otherwise define a new one which is descriptive. Thank you.
