On Mon, 2018-02-26 at 10:29 +0100, Rafael J. Wysocki wrote: > On Sun, Feb 25, 2018 at 2:23 PM, Andy Shevchenko > <andriy.shevche...@linux.intel.com> wrote: > > On Fri, 2018-02-23 at 15:35 -0600, Bjorn Helgaas wrote:
> > > but making this inline looks similar to this, which > > > wasn't well-received: > > > > > > https://lkml.kernel.org/r/CA+55aFypU331cQy- > > > 6ZJ6szF=2kvlqcbwcugd+gtwpvirqrw...@mail.gmail.com > > > > "Yes, that header file is already full of random inline functions, > > but > > they are generally wrapper functions that don't really do anything, > > ..." > > > > I think the function above is exactly from the "wrapper that doesn't > > really do anything" category. > > Yes, but honestly does it need to be inline even so? > > Why don't you simply put the wrapper into dmi_scan.c and export it? Taking into consideration that there are few comments to be addressed and series had been applied, I will send a fix up series where I move this to be a normal function. -- Andy Shevchenko <andriy.shevche...@linux.intel.com> Intel Finland Oy
