On Tue, Feb 27, 2018 at 11:15 PM, Michał Kępień <ker...@kempniu.pl> wrote: > Various functions exposed by the firmware through the FUNC interface > tend to use a consistent set of integers for denoting the type of > operation to be performed for a specified feature. Use named constants > instead of integers in each call_fext_func() invocation in order to more > clearly convey the intent of each call. > > Note that FUNC_FLAGS is a bit peculiar:
> +/* FUNC interface - operations */ > +#define OP_GET BIT(1) > +#define OP_GET_CAPS 0 > +#define OP_GET_EVENTS BIT(0) > +#define OP_GET_EXT BIT(2) > +#define OP_SET BIT(0) > +#define OP_SET_EXT (BIT(2) | BIT(0)) Hmm... this looks unordered a bit. And plain 0 doesn't look right in this concept (something like (0 << 0) would probably do it). -- With Best Regards, Andy Shevchenko
